All files / routes students.js

7.62% Statements 9/118
0% Branches 0/56
0% Functions 0/4
7.62% Lines 9/118

Press n or j to go to the next uncovered block, b, p or k for the previous block.

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 4193x 3x 3x   3x     3x                                                                                                                                                                                                                                                                                                               3x                                                                                                                                                                                                                                                                                                             3x                                                                                                                               3x                                                                                   3x    
const express = require('express');
const pool = require('../config/database');
const { authenticate, authorize } = require('../middleware/auth');
 
const router = express.Router();
 
// Get all students
router.get('/', authenticate, async (req, res) => {
  try {
    const { supervisor_id, search, status } = req.query;
    const currentUser = req.user;
 
    let query = `
      SELECT 
        s.id, s.user_id, s.program, s.start_date, s.expected_completion,
        s.supervisor_id, s.progress, s.enrollment_date,
        u.name, u.email, u.phone, u.avatar, u.status as user_status,
        COALESCE(sup.user_id, (
          SELECT ss_sup_inner.user_id 
          FROM supervisor_student ss_inner
          JOIN supervisors ss_sup_inner ON ss_inner.supervisor_id = ss_sup_inner.id
          WHERE ss_inner.student_id = s.id
          LIMIT 1
        )) as supervisor_user_id,
        COALESCE(sup_user.name, (
          SELECT ss_sup_user_inner.name 
          FROM supervisor_student ss_inner
          JOIN supervisors ss_sup_inner ON ss_inner.supervisor_id = ss_sup_inner.id
          JOIN users ss_sup_user_inner ON ss_sup_inner.user_id = ss_sup_user_inner.id
          WHERE ss_inner.student_id = s.id
          LIMIT 1
        )) as supervisor_name,
        COALESCE(sup_user.email, (
          SELECT ss_sup_user_inner.email 
          FROM supervisor_student ss_inner
          JOIN supervisors ss_sup_inner ON ss_inner.supervisor_id = ss_sup_inner.id
          JOIN users ss_sup_user_inner ON ss_sup_inner.user_id = ss_sup_user_inner.id
          WHERE ss_inner.student_id = s.id
          LIMIT 1
        )) as supervisor_email,
        COALESCE(sup.department, (
          SELECT ss_sup_inner.department 
          FROM supervisor_student ss_inner
          JOIN supervisors ss_sup_inner ON ss_inner.supervisor_id = ss_sup_inner.id
          WHERE ss_inner.student_id = s.id
          LIMIT 1
        )) as supervisor_department,
        COALESCE(sup_user.avatar, (
          SELECT ss_sup_user_inner.avatar 
          FROM supervisor_student ss_inner
          JOIN supervisors ss_sup_inner ON ss_inner.supervisor_id = ss_sup_inner.id
          JOIN users ss_sup_user_inner ON ss_sup_inner.user_id = ss_sup_user_inner.id
          WHERE ss_inner.student_id = s.id
          LIMIT 1
        )) as supervisor_avatar,
        COALESCE(sup_user.phone, (
          SELECT ss_sup_user_inner.phone 
          FROM supervisor_student ss_inner
          JOIN supervisors ss_sup_inner ON ss_inner.supervisor_id = ss_sup_inner.id
          JOIN users ss_sup_user_inner ON ss_sup_inner.user_id = ss_sup_user_inner.id
          WHERE ss_inner.student_id = s.id
          LIMIT 1
        )) as supervisor_phone,
        COALESCE(sup.position, (
          SELECT ss_sup_inner.position 
          FROM supervisor_student ss_inner
          JOIN supervisors ss_sup_inner ON ss_inner.supervisor_id = ss_sup_inner.id
          WHERE ss_inner.student_id = s.id
          LIMIT 1
        )) as supervisor_position,
        COALESCE(sup.office, (
          SELECT ss_sup_inner.office 
          FROM supervisor_student ss_inner
          JOIN supervisors ss_sup_inner ON ss_inner.supervisor_id = ss_sup_inner.id
          WHERE ss_inner.student_id = s.id
          LIMIT 1
        )) as supervisor_office,
        COALESCE(sup.research_interests, (
          SELECT ss_sup_inner.research_interests 
          FROM supervisor_student ss_inner
          JOIN supervisors ss_sup_inner ON ss_inner.supervisor_id = ss_sup_inner.id
          WHERE ss_inner.student_id = s.id
          LIMIT 1
        )) as supervisor_research_interests,
        COALESCE(sup.biography, (
          SELECT ss_sup_inner.biography 
          FROM supervisor_student ss_inner
          JOIN supervisors ss_sup_inner ON ss_inner.supervisor_id = ss_sup_inner.id
          WHERE ss_inner.student_id = s.id
          LIMIT 1
        )) as supervisor_biography
      FROM students s
      JOIN users u ON s.user_id = u.id
      LEFT JOIN supervisors sup ON s.supervisor_id = sup.id
      LEFT JOIN users sup_user ON sup.user_id = sup_user.id
      WHERE 1=1
    `;
    const params = [];
 
    // Supervisors can only see their own students (using supervisor_student table)
    if (currentUser.role === 'supervisor') {
      const [supervisor] = await pool.query(
        'SELECT id FROM supervisors WHERE user_id = ?',
        [currentUser.id]
      );
      if (supervisor.length > 0) {
        // Use supervisor_student table for many-to-many relationship
        query += ` AND s.id IN (SELECT student_id FROM supervisor_student WHERE supervisor_id = ?)`;
        params.push(supervisor[0].id);
      } else {
        return res.json({ students: [] });
      }
    }
 
    // Students can only see their own data
    if (currentUser.role === 'student') {
      const [student] = await pool.query(
        'SELECT id FROM students WHERE user_id = ?',
        [currentUser.id]
      );
      if (student.length > 0) {
        query += ' AND s.id = ?';
        params.push(student[0].id);
      } else {
        return res.json({ students: [] });
      }
    }
 
    if (supervisor_id) {
      query += ' AND s.supervisor_id = ?';
      params.push(supervisor_id);
    }
 
    if (status) {
      query += ' AND u.status = ?';
      params.push(status);
    }
 
    if (search) {
      query += ' AND (u.name LIKE ? OR u.email LIKE ? OR s.program LIKE ?)';
      const searchTerm = `%${search}%`;
      params.push(searchTerm, searchTerm, searchTerm);
    }
 
    query += ' ORDER BY u.name ASC';
 
    const [students] = await pool.query(query, params);
    // Set cache headers to prevent caching and ensure real-time data
    res.set('Cache-Control', 'no-store, no-cache, must-revalidate, proxy-revalidate');
    res.set('Pragma', 'no-cache');
    res.set('Expires', '0');
    res.json({ students });
  } catch (error) {
    console.error('Get students error:', error);
    res.status(500).json({ error: 'Failed to fetch students' });
  }
});
 
// Get student by ID
router.get('/:id', authenticate, async (req, res) => {
  try {
    const studentId = parseInt(req.params.id);
    const currentUser = req.user;
 
    let query = `
      SELECT 
        s.*, u.name, u.email, u.phone, u.avatar, u.status as user_status,
        COALESCE(sup.user_id, (
          SELECT ss_sup_inner.user_id 
          FROM supervisor_student ss_inner
          JOIN supervisors ss_sup_inner ON ss_inner.supervisor_id = ss_sup_inner.id
          WHERE ss_inner.student_id = s.id
          LIMIT 1
        )) as supervisor_user_id,
        COALESCE(sup_user.name, (
          SELECT ss_sup_user_inner.name 
          FROM supervisor_student ss_inner
          JOIN supervisors ss_sup_inner ON ss_inner.supervisor_id = ss_sup_inner.id
          JOIN users ss_sup_user_inner ON ss_sup_inner.user_id = ss_sup_user_inner.id
          WHERE ss_inner.student_id = s.id
          LIMIT 1
        )) as supervisor_name,
        COALESCE(sup_user.email, (
          SELECT ss_sup_user_inner.email 
          FROM supervisor_student ss_inner
          JOIN supervisors ss_sup_inner ON ss_inner.supervisor_id = ss_sup_inner.id
          JOIN users ss_sup_user_inner ON ss_sup_inner.user_id = ss_sup_user_inner.id
          WHERE ss_inner.student_id = s.id
          LIMIT 1
        )) as supervisor_email,
        COALESCE(sup.department, (
          SELECT ss_sup_inner.department 
          FROM supervisor_student ss_inner
          JOIN supervisors ss_sup_inner ON ss_inner.supervisor_id = ss_sup_inner.id
          WHERE ss_inner.student_id = s.id
          LIMIT 1
        )) as supervisor_department,
        COALESCE(sup_user.avatar, (
          SELECT ss_sup_user_inner.avatar 
          FROM supervisor_student ss_inner
          JOIN supervisors ss_sup_inner ON ss_inner.supervisor_id = ss_sup_inner.id
          JOIN users ss_sup_user_inner ON ss_sup_inner.user_id = ss_sup_user_inner.id
          WHERE ss_inner.student_id = s.id
          LIMIT 1
        )) as supervisor_avatar,
        COALESCE(sup_user.phone, (
          SELECT ss_sup_user_inner.phone 
          FROM supervisor_student ss_inner
          JOIN supervisors ss_sup_inner ON ss_inner.supervisor_id = ss_sup_inner.id
          JOIN users ss_sup_user_inner ON ss_sup_inner.user_id = ss_sup_user_inner.id
          WHERE ss_inner.student_id = s.id
          LIMIT 1
        )) as supervisor_phone,
        COALESCE(sup.position, (
          SELECT ss_sup_inner.position 
          FROM supervisor_student ss_inner
          JOIN supervisors ss_sup_inner ON ss_inner.supervisor_id = ss_sup_inner.id
          WHERE ss_inner.student_id = s.id
          LIMIT 1
        )) as supervisor_position,
        COALESCE(sup.office, (
          SELECT ss_sup_inner.office 
          FROM supervisor_student ss_inner
          JOIN supervisors ss_sup_inner ON ss_inner.supervisor_id = ss_sup_inner.id
          WHERE ss_inner.student_id = s.id
          LIMIT 1
        )) as supervisor_office,
        COALESCE(sup.research_interests, (
          SELECT ss_sup_inner.research_interests 
          FROM supervisor_student ss_inner
          JOIN supervisors ss_sup_inner ON ss_inner.supervisor_id = ss_sup_inner.id
          WHERE ss_inner.student_id = s.id
          LIMIT 1
        )) as supervisor_research_interests,
        COALESCE(sup.biography, (
          SELECT ss_sup_inner.biography 
          FROM supervisor_student ss_inner
          JOIN supervisors ss_sup_inner ON ss_inner.supervisor_id = ss_sup_inner.id
          WHERE ss_inner.student_id = s.id
          LIMIT 1
        )) as supervisor_biography
      FROM students s
      JOIN users u ON s.user_id = u.id
      LEFT JOIN supervisors sup ON s.supervisor_id = sup.id
      LEFT JOIN users sup_user ON sup.user_id = sup_user.id
      WHERE s.id = ?
      LIMIT 1
    `;
 
    const [students] = await pool.query(query, [studentId]);
 
    if (students.length === 0) {
      return res.status(404).json({ error: 'Student not found' });
    }
 
    const student = students[0];
 
    // Check access permissions
    if (currentUser.role === 'student') {
      const [currentStudent] = await pool.query(
        'SELECT id FROM students WHERE user_id = ?',
        [currentUser.id]
      );
      if (currentStudent.length === 0 || currentStudent[0].id !== studentId) {
        return res.status(403).json({ error: 'Access denied' });
      }
    } else if (currentUser.role === 'supervisor') {
      const [supervisor] = await pool.query(
        'SELECT id FROM supervisors WHERE user_id = ?',
        [currentUser.id]
      );
      if (supervisor.length === 0) {
        return res.status(403).json({ error: 'Access denied' });
      }
      // Check if student is in supervisor_student relationship table
      const [relationship] = await pool.query(
        'SELECT id FROM supervisor_student WHERE supervisor_id = ? AND student_id = ?',
        [supervisor[0].id, studentId]
      );
      if (relationship.length === 0) {
        return res.status(403).json({ error: 'Access denied' });
      }
    }
 
    // Get milestones
    const [milestones] = await pool.query(
      'SELECT * FROM milestones WHERE student_id = ? ORDER BY created_at ASC',
      [studentId]
    );
 
    // Get recent progress logs
    const [progressLogs] = await pool.query(
      'SELECT * FROM progress_logs WHERE student_id = ? ORDER BY created_at DESC LIMIT 10',
      [studentId]
    );
 
    res.json({
      student: {
        ...student,
        milestones,
        recentProgressLogs: progressLogs
      }
    });
  } catch (error) {
    console.error('Get student error:', error);
    res.status(500).json({ error: 'Failed to fetch student' });
  }
});
 
// Update student
router.put('/:id', authenticate, async (req, res) => {
  try {
    const studentId = parseInt(req.params.id);
    const currentUser = req.user;
    const { program, start_date, expected_completion, supervisor_id, progress, research_area } = req.body;
 
    // Check access
    if (currentUser.role === 'student') {
      const [student] = await pool.query(
        'SELECT id FROM students WHERE user_id = ?',
        [currentUser.id]
      );
      if (student.length === 0 || student[0].id !== studentId) {
        return res.status(403).json({ error: 'Access denied' });
      }
    }
 
    const updates = [];
    const params = [];
 
    if (program !== undefined) {
      updates.push('program = ?');
      params.push(program);
    }
    if (start_date !== undefined) {
      updates.push('start_date = ?');
      params.push(start_date);
    }
    if (expected_completion !== undefined) {
      updates.push('expected_completion = ?');
      params.push(expected_completion);
    }
    if (supervisor_id !== undefined && currentUser.role === 'administrator') {
      updates.push('supervisor_id = ?');
      params.push(supervisor_id);
    }
    if (progress !== undefined) {
      updates.push('progress = ?');
      params.push(progress);
    }
    if (research_area !== undefined) {
      updates.push('research_area = ?');
      params.push(research_area);
    }
 
    if (updates.length === 0) {
      return res.status(400).json({ error: 'No fields to update' });
    }
 
    params.push(studentId);
 
    await pool.query(
      `UPDATE students SET ${updates.join(', ')} WHERE id = ?`,
      params
    );
 
    res.json({ message: 'Student updated successfully' });
  } catch (error) {
    console.error('Update student error:', error);
    res.status(500).json({ error: 'Failed to update student' });
  }
});
 
// Assign supervisor to student (admin only)
router.post('/:id/assign-supervisor', authenticate, authorize('administrator'), async (req, res) => {
  try {
    const studentId = parseInt(req.params.id);
    const { supervisor_id } = req.body;
 
    if (!supervisor_id) {
      return res.status(400).json({ error: 'Supervisor ID is required' });
    }
 
    // Check if supervisor has capacity
    const [supervisor] = await pool.query(
      'SELECT capacity, current_students FROM supervisors WHERE id = ?',
      [supervisor_id]
    );
 
    if (supervisor.length === 0) {
      return res.status(404).json({ error: 'Supervisor not found' });
    }
 
    if (supervisor[0].current_students >= supervisor[0].capacity) {
      return res.status(400).json({ error: 'Supervisor has reached capacity' });
    }
 
    // Update student
    await pool.query(
      'UPDATE students SET supervisor_id = ? WHERE id = ?',
      [supervisor_id, studentId]
    );
 
    // Update supervisor student count
    await pool.query(
      'UPDATE supervisors SET current_students = current_students + 1 WHERE id = ?',
      [supervisor_id]
    );
 
    res.json({ message: 'Supervisor assigned successfully' });
  } catch (error) {
    console.error('Assign supervisor error:', error);
    res.status(500).json({ error: 'Failed to assign supervisor' });
  }
});
 
module.exports = router;